Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ SmileWanted new ad code support #23447

Merged
merged 5 commits into from
Sep 13, 2019
Merged

Conversation

MaxSmileWanted
Copy link
Contributor

This PR adds support for a new ad code that SmileWanted would like to start using within our AMP widgets.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MaxSmileWanted MaxSmileWanted changed the title ✨ SmileWanted new ad code support ✨ SmileWanted new ad code support Jul 21, 2019
@MaxSmileWanted
Copy link
Contributor Author

I signed the CLA ;)

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@MaxSmileWanted
Copy link
Contributor Author

Please can someone review this PR ;)

@MaxSmileWanted
Copy link
Contributor Author

@jridgewell Hello can you asign someone to review to review this PR.

@jridgewell
Copy link
Contributor

@lannka

@lannka lannka self-requested a review September 13, 2019 21:37
@lannka lannka merged commit 738cca1 into ampproject:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants