🧹 Badges #23591
Merged
🧹 Badges #23591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jul 30, 2019
| [](https://travis-ci.org/ampproject/amphtml/builds) | ||
| [](https://github.com/ampproject/amphtml/releases) | ||
| [](https://github.com/ampproject/amphtml/graphs/contributors) | ||
| [](https://github.com/ampproject/amphtml/pulse/monthly) | ||
| [](#) |
There was a problem hiding this comment.
Can we use the AMP logo instead of the GitHub logo for this one? If there isn't one, maybe use a smiley instead :)
There was a problem hiding this comment.
A URL to an SVG can be provided via the logoSvg URL param; alternately, since the bolt is unicode, it could just be a part of the label (although in my experience that kinda throws off the kerning a smidge). Also I can't believe we're actually adding a badge-badge 😆
rcebulko
reviewed
Jul 30, 2019
| @@ -1,33 +1,37 @@ | |||
| # AMP ⚡ | |||
|
|
|||
| ##### Stats: | |||
There was a problem hiding this comment.
Do we want a "Badges" subheader here? No opinion either way just a thought as I look at these being removed.
rcebulko
approved these changes
Jul 30, 2019
mrjoro
approved these changes
Aug 8, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* 🧹 Badges - Removes issue/PR badges. - Metrics and tooling are collapsed. Overall makes things neater, less jumpy, and lifts actual content. Also added badge count badge for the luls * i can't count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall makes things neater, less jumpy, and lifts actual content.
Also added badge count badge for the luls