New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update analytics vendor split experiments config #23604
✨ Update analytics vendor split experiments config #23604
Conversation
cc @zhouyx for review :) cc @erwinmombay just want to make sure, is running 2 commands during experiment builds okay? e.g. |
A few notes on this PR:
|
@@ -386,7 +386,7 @@ function buildExtension( | |||
} | |||
|
|||
// minify and copy vendor configs for amp-analytics component | |||
if (name === 'amp-analytics' && argv.compile_vendor_configs) { | |||
if (name === 'amp-analytics') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathantyng-amp could you please confirm that the build works even if gulp generate-vendor-jsons
hasn't been run (no such json files to copy). In that case what will happen? Will the analytics-vendors folder be created? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and confirmed that build works with no JSON files to copy. If there are no vendor JSONs, dist/analytics-vendors
folder will not be created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks
gulp generate-vendor-configs
to experiments command so that vendor JSONs are generated during the experiment build--compile_vendor_configs
by default, so no need to add this flag anymore