✨ Add RTV serve_mode #23611
Merged
✨ Add RTV serve_mode #23611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zhouyx for review :) |
|
LGTM! Any idea on if the rtv doesn't exist, should we just let it timeout? |
zhouyx
approved these changes
Aug 6, 2019
Yeah I think thats the best option |
|
Just used this feature and it's extremely useful!! THANK YOU 🎉 |
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* allow rtv serve mode * temp * replace urls to rtv url * docs and replace URL * cleanup * whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
serve_modethat uses a build from a specific RTV branch. Set theserve_modewith the RTV number you want (including the first 2 version digits).E.g.
http://localhost:8000/serve_mode=001907231757120will set the serve mode to use the001907231757120RTV branch and requests will go tohttps://cdn.ampproject.org/rtv/001907231757120/*