Launch AdSense Canonical Impl Support #23620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Jul 31, 2019
| isExperimentOn(this.win_, 'inabox-position-api') | ||
| isExperimentOn(this.win_, 'inabox-position-api') || | ||
| (/^adsense$/i.test(this.element_.getAttribute('type')) && | ||
| !isGoogleAdsA4AValidEnvironment(this.win_)) |
There was a problem hiding this comment.
do you know if AdSense using this position API? It's a bit weird to me that this opt-in based experiment is fully enabled to all AdSense A4A ineligible traffic?
There was a problem hiding this comment.
This was added to ensure that AMP creatives returned would have access to this information. Since there is no way to know (or trust) that the creative is or is not AMP, we decided to just give access to all AdSense canonical creatives.
There was a problem hiding this comment.
thx for explaining. would you pls add it as a comment to the code?
lannka
approved these changes
Jul 31, 2019
| isExperimentOn(this.win_, 'inabox-position-api') | ||
| isExperimentOn(this.win_, 'inabox-position-api') || | ||
| (/^adsense$/i.test(this.element_.getAttribute('type')) && | ||
| !isGoogleAdsA4AValidEnvironment(this.win_)) |
There was a problem hiding this comment.
thx for explaining. would you pls add it as a comment to the code?
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Launch AdSense Canonical Impl Support * remove adsense delay fetch test * improve comment related to position API observer * fix test failure * fix lint failure * fix test failure due to AdSense upgrade * fix test failure due to AdSense upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch usage of amp-ad-network-adsense-impl for Adsense canonical (non-AMP cache) traffic currently relying on delayed fetch.