fixed nativeroll's player collapse & resize bug #23656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Aug 2, 2019
ads/nativeroll.js
Outdated
| @@ -39,6 +39,9 @@ function initPlayer(data) { | |||
| container: '#c', | |||
| desiredOffset: 50, | |||
| gid: data.gid, | |||
| onError: () => { | |||
| window.context.noContentAvailable(); | |||
There was a problem hiding this comment.
please pass down the window from caller (global)
There was a problem hiding this comment.
Or i need something like "global.window.contex..."?
There was a problem hiding this comment.
function initPlayer(global, data) {
...
global.context.noContentAvailable();
}
n-randin
changed the title
|
@lannka Hi, can you check this again? thx |
lannka
reviewed
Aug 6, 2019
| @@ -39,6 +39,14 @@ function initPlayer(data) { | |||
| container: '#c', | |||
| desiredOffset: 50, | |||
| gid: data.gid, | |||
| onError: () => { | |||
| global.context.noContentAvailable(); | |||
There was a problem hiding this comment.
you need pass global object as function param
There was a problem hiding this comment.
ah, ok, did not immediately understand what you mean. Done this.
lannka
approved these changes
Aug 8, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* fixed nativeroll's player collapse bug * window from global * use global & adding requestResize on content load * use global & adding requestResize on content load * /*ok*/ to the offsetHeight * pass global as param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lannka
@zhouyx
Help with merge this plz.