Add canvas support in amp-script #23658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested review from
Gregable,
dreamofabear and
alin04
and removed request for
Gregable
Gregable
reviewed
Aug 2, 2019
| # CANVAS support. | ||
| tags: { | ||
| html_format: AMP | ||
| tag_name: "CANVAS" |
There was a problem hiding this comment.
Since this is a standard HTML element, would you mind moving it to validator-main.protoascii under the appropriate HTML spec header?
You can leave the mandatory_ancestor thing here, and leave a comment describing where to look.
Gregable
approved these changes
Aug 2, 2019
|
@choumx friendly ping. Want to make sure you were aware of this change. |
dreamofabear
approved these changes
Aug 5, 2019
| @@ -3839,6 +3839,9 @@ tags: { | |||
| # 4.8 Links | |||
| # Links are a concept, rather than a tag. See tagspecs for "LINK", "A", etc. | |||
|
|
|||
| # 4.8.11 The canvas element | |||
| # See extensions/amp-mustache/validator-amp-script.protoascii | |||
There was a problem hiding this comment.
I think Greg means moving the entire canvas tag spec here with a comment for mandatory_ancestor.
There was a problem hiding this comment.
right. He is also fine with this approach as long as one as point out in main where the rule is defined. Thanks
examples/amp-script/example.amp.html
Outdated
| <h1>Example: hello-world.js</h1> | ||
| <amp-script layout=container src="/examples/amp-script/hello-world.js"> | ||
| <h1>Example: example.js</h1> | ||
| <amp-script layout=container src="/examples/amp-script/example.js"> |
There was a problem hiding this comment.
Can we name this something other than its grandparent folder name? Maybe amp-script-demo.js.
rsimha
pushed a commit
that referenced
this pull request
Aug 8, 2019
* cl/261776511 Add ValidationError::DEV_MODE_ONLY error code. * cl/261804799 Improve amp-date-picker and amp-carousel validator errors. * cl/261931393 Revision bump for #23598 * cl/262032455 Allow additional CSS features. * cl/262149003 Allow double-spaces in <a rel> and <link rel>. * cl/262178521 Revision bump for #23691 * cl/262193876 Revision bump for #23658 * cl/262223028 Revision bump for #23752 * cl/262230380 Revision bump for #23727 * Fix merge duplication mistakes.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* add canvas support in amp-script * new files * file renamed * address @Gregable comments * fix test after rule changes * fix test * name change * rename example.js to amp-script-demo.js * update file from rename
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* cl/261776511 Add ValidationError::DEV_MODE_ONLY error code. * cl/261804799 Improve amp-date-picker and amp-carousel validator errors. * cl/261931393 Revision bump for ampproject#23598 * cl/262032455 Allow additional CSS features. * cl/262149003 Allow double-spaces in <a rel> and <link rel>. * cl/262178521 Revision bump for ampproject#23691 * cl/262193876 Revision bump for ampproject#23658 * cl/262223028 Revision bump for ampproject#23752 * cl/262230380 Revision bump for ampproject#23727 * Fix merge duplication mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23579
Validator changes to allow for canvas element in amp-script block