Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix unit test paths #23717

Merged
merged 2 commits into from Aug 6, 2019
Merged

馃悰 Fix unit test paths #23717

merged 2 commits into from Aug 6, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 5, 2019

Fixes #23704

@rsimha rsimha self-assigned this Aug 5, 2019
@dreamofabear
Copy link

Note this doesn't fix the amp-addthis case which uses subfolders that are not named "unit".

@rsimha
Copy link
Contributor Author

rsimha commented Aug 6, 2019 •
edited

Note this doesn't fix the amp-addthis case which uses subfolders that are not named "unit".

Unfortunately, it's not possible to include all test files in all subfolders, since some of them might be integration or e2e tests.

I'll merge this for now, since it fixes some of the scenarios, and leave the rest for #20197.

@dreamofabear dreamofabear mentioned this pull request Aug 6, 2019
Closed
@rsimha rsimha merged commit b98ca12 into ampproject:master Aug 6, 2019
@rsimha rsimha deleted the 2019-08-05-TestPaths branch August 6, 2019 15:16
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@rsimha
馃悰 Fix unit test paths (ampproject#23717)
800024e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests in extensions subfolders don't run
3 participants
@rsimha @dreamofabear @googlebot