amp-bind: Support special chars in strings #23811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
force-pushed
the
bind-special-chars
branch
from
ba3f568
to
97210de
Compare
|
/to @jridgewell |
jridgewell
reviewed
Aug 8, 2019
| @@ -205,6 +205,17 @@ describe('BindExpression', () => { | |||
| expect(evaluate('+"1"')).to.equal(1); | |||
| }); | |||
|
|
|||
| it('should parse special characters', () => { | |||
| expect(evaluate('"\\n"')).to.equal('\n'); | |||
There was a problem hiding this comment.
What does this look like when written in HTML?
| const string = yytext.substr(1, yyleng - 2); | ||
| // Replace leading/trailing single-quote with double-quote chars and | ||
| // use JSON.parse() to process special chars e.g. '\n'. | ||
| const string = parseJson(`"${yytext.substr(1, yyleng - 2)}"`); |
There was a problem hiding this comment.
Is this safe? What if we used a single quote and the string includes double quotes inside it?
There was a problem hiding this comment.
Attribute values can't have double quotes.
There was a problem hiding this comment.
Note, this will also transform unicode escapes (\u0000) into their unicode chars.
There was a problem hiding this comment.
<div attr='foo"bar'> is legal HTML
jridgewell
approved these changes
Aug 8, 2019
| const string = yytext.substr(1, yyleng - 2); | ||
| // Replace leading/trailing single-quote with double-quote chars and | ||
| // use JSON.parse() to process special chars e.g. '\n'. | ||
| const string = parseJson(`"${yytext.substr(1, yyleng - 2)}"`); |
There was a problem hiding this comment.
Note, this will also transform unicode escapes (\u0000) into their unicode chars.
jridgewell
requested changes
Aug 8, 2019
| const string = yytext.substr(1, yyleng - 2); | ||
| // Replace leading/trailing single-quote with double-quote chars and | ||
| // use JSON.parse() to process special chars e.g. '\n'. | ||
| const string = parseJson(`"${yytext.substr(1, yyleng - 2)}"`); |
There was a problem hiding this comment.
<div attr='foo"bar'> is legal HTML
jridgewell
approved these changes
Aug 9, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Support special chars. * Fix single quote strings. * Fix presubmit, add test. * Add test for escaping special chars. * Escape double-quotes in strings and fallback to non-parsed string. * Use regex with /g. * One more test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17863 and fixes #22265.