Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<amp-experiment> 1.0: do not select internal elements #23881

Merged
merged 3 commits into from Aug 23, 2019
Merged

<amp-experiment> 1.0: do not select internal elements #23881

merged 3 commits into from Aug 23, 2019

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Aug 9, 2019

No description provided.

@zhouyx zhouyx requested a review from lannka August 9, 2019 23:29
@zhouyx zhouyx added Blocked and removed Blocked labels Aug 16, 2019
lannka
lannka requested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test

@zhouyx
Copy link
Contributor Author

zhouyx commented Aug 20, 2019

Added unit test coverage

@zhouyx zhouyx merged commit 61ba634 into ampproject:master Aug 23, 2019
@zhouyx zhouyx deleted the amp-experiment-selector branch August 23, 2019 18:01
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@zhouyx
<amp-experiment> 1.0: do not select internal elements (ampproject#23881)
2a23f8c 
* do not allow i-amphtml

* lint

* unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhouyx @lannka @googlebot