Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Move facebook-loader.js into its component directory #23897

Merged
merged 1 commit into from
Aug 12, 2019
Merged

🐛 Move facebook-loader.js into its component directory #23897

merged 1 commit into from
Aug 12, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 12, 2019

This PR moves facebook-loader.js into its component directory to fix these (currently silenced) type checking errors, which stem from the fact that extension code is expected to live in a directory of the format amp-foo/0.x/. See #23084 (comment) for more details.

Type checking failed:
extensions/amp-facebook-comments/0.1/amp-facebook-comments.js:17: ERROR - [JSC_JS_MODULE_LOAD_WARNING] Failed to load module "../../amp-facebook/facebook-loader"
import {createLoaderLogo} from '../../amp-facebook/facebook-loader';
^

extensions/amp-facebook-page/0.1/amp-facebook-page.js:17: ERROR - [JSC_JS_MODULE_LOAD_WARNING] Failed to load module "../../amp-facebook/facebook-loader"
import {createLoaderLogo} from '../../amp-facebook/facebook-loader';
^

extensions/amp-facebook/0.1/amp-facebook.js:17: ERROR - [JSC_JS_MODULE_LOAD_WARNING] Failed to load module "../facebook-loader"
import {createLoaderLogo} from '../facebook-loader';
^

Addresses #23084 (comment)

@rsimha rsimha merged commit f718c8e into ampproject:master Aug 12, 2019
@rsimha rsimha deleted the 2019-08-12-FacebookLoader branch August 12, 2019 18:20
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants