Enable a4a friendly iframe css splitting for prod #23933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
Aug 14, 2019
lannka
requested changes
Dec 23, 2019
|
@powerivq is this launch stable now? We can move forward with this clean up? |
powerivq
force-pushed
the
enable-css-split
branch
2 times, most recently
from
bea3f28
to
f39ade3
Compare
|
@dvoytenko for approval of friendly-iframe-embed. @lannka Should we change to make ampproject/wg-ads own that file? |
lannka
approved these changes
Jan 28, 2020
|
Is this PR ready to go? |
powerivq
force-pushed
the
enable-css-split
branch
from
f39ade3
to
39663cd
Compare
|
@lannka Yes. I was waiting for dima's owner approval, but my other PR made wg-ads an owner, so it is unblocked. |
|
Sorry, missed this PR. What does it do exactly? Is it simply cleaning up the launched feature? |
|
@dvoytenko Yes. |
dvoytenko
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove experiment related code and release the feature.
closes #22418