Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Add trailing slash to event endpoint to return gif in response to GET request #23958

Merged
merged 1 commit into from Oct 2, 2019

Conversation

tygavin
Copy link
Contributor

@tygavin tygavin commented Aug 14, 2019

Minor update for console warning.

The trailing / included in the collect.tealiumiq.com endpoint will ensure an "image/gif" HTTP response instead of the current "application/json" response.

The current application/json response resulted in console warning messages when the browser is looking for a response that has Content-Length greater than 0. This fixes the warning message.

@tygavin
Copy link
Contributor Author

tygavin commented Sep 4, 2019

@jeffjose A minor update for Tealium requires review. Thanks for your help.

@jeffjose jeffjose requested a review from lannka September 4, 2019 15:46
@jeffjose
Copy link
Contributor

jeffjose commented Sep 4, 2019

LGTM from my side. Over to @lannka for approvals.

@amp-owners-bot amp-owners-bot bot requested a review from avimehta October 2, 2019 02:52
Copy link
Contributor

@avimehta avimehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The change looks fine.
  • @tygavin previously added Tealium to AMP in this pr
  • I have not been able to trigger this endpoint on real sites but the endpoint returns html/gif response.

Overall LGTM.

@avimehta
Copy link
Contributor

avimehta commented Oct 2, 2019

@lannka or @zhouyx: Do you mind merging. I technically can but since you are the owners, I don't want to step on your toes.

@lannka
Copy link
Contributor

lannka commented Oct 2, 2019

thanks Avi

@lannka lannka merged commit c8304c4 into ampproject:master Oct 2, 2019
@zhouyx
Copy link
Contributor

zhouyx commented Oct 2, 2019

Thank you @avimehta!

@rcebulko another question, can we keep Avi as the owner but not having the owner bot automatically request reviews from them. Otherwise they'll get a lot of review requests 馃槇

@rcebulko
Copy link
Contributor

rcebulko commented Oct 2, 2019

You can prefix his username in the OWNERS.yaml file with ?, ie. - "?avimehta" and he will never be automatically requested as reviewer.

@zhouyx
Copy link
Contributor

zhouyx commented Oct 2, 2019

Thanks! Will summit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants