Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add support for lazy loading on amp-ad appnexus adapter #24070

Merged
merged 8 commits into from Aug 26, 2019
Merged

✨ Add support for lazy loading on amp-ad appnexus adapter #24070

merged 8 commits into from Aug 26, 2019

Conversation

deekshithraop
Copy link
Contributor

This pull req adds the ability to delay the request of ads on infinite scroll pages.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@deekshithraop
Copy link
Contributor Author

@zhouyx could you please look into this PR.

@deekshithraop
Copy link
Contributor Author

CC: @jsnellbaker

@zhouyx
Copy link
Contributor

zhouyx commented Aug 20, 2019

to @ampproject/ads

calebcordry
calebcordry reviewed Aug 20, 2019
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continued support of this extension! Just a couple of questions.

ads/appnexus.md Outdated
@@ -65,6 +65,30 @@ Note: you should use either the basic setup or AST setup. Do not mix types on th
</amp-ad>
```

### AST Infinite scroll ads on the page, Include adUnit details only in the amp-ad tag which you want to lazy load
Note: You would loose competitive exclusion if you use this setup.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

examples/ads.amp.html Outdated
</amp-ad>
</amp-ad>

<amp-ad width="300" height="250"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a creative here, is it possible to render one? It helps us with our future debugging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We left it to test how would it behave if there was no bid for this tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment above the example explaining. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

examples/ads.amp.html Outdated

<amp-ad width="728" height="90"
<amp-ad width="728" height="90"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you make indentation consistent across the three examples here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

calebcordry
calebcordry approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for contributing! Looks like a percy flake. I restarted the test. Ill try to keep an eye on it but let me know if you see it pass

@deekshithraop
Copy link
Contributor Author

Looks like all the required checks are cleared. Thanks

@calebcordry calebcordry merged commit 397ffd7 into ampproject:master Aug 26, 2019
@calebcordry
Copy link
Member

Merged! Thanks again.

@deekshithraop
Copy link
Contributor Author

Thank you, when can we expect these changes to go live.

@calebcordry
Copy link
Member

This should be released in the new canary tomorrow, and production the following week. For more details please check out the release schedule documentation. Let me know if you have any questions.

thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@deekshithraop @calebcordry
✨ Add support for lazy loading on amp-ad appnexus adapter (ampproject…
ddda2fb 
…#24070)

* appnexus Add support for multiple loadTags

* Update appnexus ad example

* Add docs for amp-ads appnexus lazyload

* resize example ad appnexus tag

* update docs appnexus ads

* change Array includes to indexOf

* review changes

* code review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deekshithraop @googlebot @zhouyx @calebcordry