<amp-experiment> 1.0 add style mutation support #24089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
requested changes
Aug 20, 2019
| const SUPPORTED_STYLE_VALUE = { | ||
| 'color': /#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3});?$/, | ||
| 'color': /.*/, |
There was a problem hiding this comment.
might worth to extract a regex constant for this to save CPU on regex parsing and instantiation.
or maybe even set it to true and skip the regex matching.
There was a problem hiding this comment.
Done. I wanted to set the value to true and skip the regex matching. But there's tradeoff there, the code looks less cleaner. Ended up extracting the regex constant.
lannka
approved these changes
Aug 20, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* add supported style * constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following list of style property support
Support all values:
colorbackground-colorfont-sizebackground-imageborder-widthborder-styleborder-colorSupport a list of values
visibility:hiddendisplay:noneposition:static/relative/absolute/initial/inheritSupport mutation for NON AMP elements only
widthandheight(all values)