Adding support for amp_ad puffnetwork #24102

yash-pn · 2019-08-21T16:26:26Z

Adding support for amp_ad puffnetwork

<amp-ad width="300" height="250"
	type="puffnetwork"
	data-chid=233 >
</amp-ad>

yash-pn · 2019-08-23T05:56:23Z

Hi @zhouyx , can you please check my PR. This is for supporting ad-network 'puffnetwork'.

yash-pn · 2019-09-06T07:11:57Z

cc: @lannka - Hi, please let me know if I am missing anything or this PR is it good to be merged?

zhouyx · 2019-09-09T04:35:34Z

Hi @yash-pn Sorry for the late response. I am currently out of office. To @ampproject/ads to review. @lannka please reassign reviewer. Thank you.

ads/_config.js

yash-pn · 2019-09-16T15:37:03Z

Hi @lannka I have implemented the changes requested. Please review.

Adding support for amp-ad puffnetwork

c6f5beb

googlebot added the cla: yes label Aug 21, 2019

zhouyx requested a review from lannka September 9, 2019 04:34

lannka requested changes Sep 13, 2019

View reviewed changes

ads/_config.js Show resolved Hide resolved

Adding support for renderStartImplemented

ad2dc34

yash-pn requested a review from lannka September 16, 2019 15:34

lannka approved these changes Sep 24, 2019

View reviewed changes

lannka merged commit 3a655f8 into ampproject:master Sep 24, 2019

Provide feedback