Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Print a message before a Karma browser starts running tests #24117

Merged
merged 1 commit into from Aug 21, 2019
Merged

🏗 Print a message before a Karma browser starts running tests #24117

merged 1 commit into from Aug 21, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 21, 2019

Karma tests are run in batches on Sauce Labs browsers. If a batch stalls for some reason, it's hard to tell which browsers were in that batch, and which browser stalled.

This PR prints a message for each browser_start event to help figure out which browsers are currently running tests.

@rsimha rsimha requested a review from estherkim August 21, 2019 19:20
@rsimha rsimha self-assigned this Aug 21, 2019
@rsimha rsimha merged commit dbac6d2 into ampproject:master Aug 21, 2019
@rsimha rsimha deleted the 2019-08-21-KarmaBrowserStart branch August 21, 2019 22:21
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants