Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build more extensions while gulp --extensions=inabox #24126

Merged
merged 1 commit into from Aug 22, 2019

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Aug 21, 2019

No description provided.

@sparhami
Copy link

Just as a FYI, I ended up making a similar change for amp-auto-lightbox in #24137, but to always build it. If this goes in first, I'll remove it from the INABOX_EXTENSION_SET.

@lannka
Copy link
Contributor Author

lannka commented Aug 22, 2019

@sparhami let's see who pass tests first. feel free to merge your PR first if it wins

@lannka lannka merged commit 1cbaae6 into ampproject:master Aug 22, 2019
@lannka lannka deleted the more-inabox-extensions branch August 22, 2019 01:02
@lannka
Copy link
Contributor Author

lannka commented Aug 22, 2019

@sparhami sorry before you

thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants