Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Always build amp-loader and amp-auto-lightbox (adapted from #24137) #24193

Merged
merged 1 commit into from Aug 24, 2019
Merged

🏗 Always build amp-loader and amp-auto-lightbox (adapted from #24137) #24193

merged 1 commit into from Aug 24, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 23, 2019

This PR picks up where #24137 left off.

Highlights:

  • Always include amp-loader and amp-auto-lightbox in the list of extensions to be built
  • Refactor getExtensionsToBuild() and buildExtensions()
  • Remove the defunct options.CompileAll
  • Use options.compileOnlyCss to determine if buildExtensions() should build just CSS (for all extensions)
  • Minor clean up

Addresses #24137 (review)
Closes #24137

@rsimha
Copy link
Contributor Author

rsimha commented Aug 24, 2019

@sparhami Here are some things to try locally with this PR:

gulp --noextensions
gulp --extensions=amp-foo,amp-bar
gulp
gulp dist --noextensions
gulp dist --extensions=amp-foo,amp-bar

amp-loader and amp-auto-lightbox should be built in all these cases.

@rsimha rsimha requested a review from lannka August 24, 2019 01:56
@rsimha rsimha merged commit bc5ec70 into ampproject:master Aug 24, 2019
@rsimha rsimha deleted the 2019-08-23-DefaultExtensions branch August 24, 2019 06:36
@sparhami
Copy link

Just a note, this PR removes some functionality I have relied on in the past (using both extensions_from and extensions together), which I have found useful when working on multiple extensions at once.

@rsimha
Copy link
Contributor Author

rsimha commented Aug 26, 2019

Just a note, this PR removes some functionality I have relied on in the past (using both extensions_from and extensions together), which I have found useful when working on multiple extensions at once.

Gotcha. Should be easy to reorganize the if clauses to restore this.

Edit: Fix available in #24227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants