Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Array.indexOf instead of Array.includes to fix a regression in amp4ads-host.js #24220

Merged
merged 1 commit into from Aug 27, 2019
Merged

Use Array.indexOf instead of Array.includes to fix a regression in amp4ads-host.js #24220

merged 1 commit into from Aug 27, 2019

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Aug 26, 2019

Mitigate #24219

/cc @zombifier

@lannka lannka requested a review from dvoytenko August 26, 2019 22:20
@lannka lannka merged commit 97cd2f3 into ampproject:master Aug 27, 2019
@lannka lannka deleted the includes-indexof branch August 27, 2019 15:53
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@lannka
Use Array.indexOf instead of Array.includes to fix a regression in am…
4faecfe 
…p4ads-host.js (ampproject#24220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkaufman jeffkaufman jeffkaufman approved these changes

@dvoytenko dvoytenko dvoytenko approved these changes

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lannka @jeffkaufman @dvoytenko @googlebot