-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Ad.Style to AMP #24264
Merged
Merged
Integrating Ad.Style to AMP #24264
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3b23856
Integrating AdStyle with AMP
ZagiMo 9c84abf
AdStyle network added
ZagiMo 48897eb
renderStart support added
ZagiMo 856e24c
minor lint fix
ZagiMo c344c7b
sorted alphabetically
ZagiMo 25cd088
renderStart removed
ZagiMo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/** | ||
* Copyright 2019 The AMP HTML Authors. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS-IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import {loadScript, validateData} from '../3p/3p'; | ||
|
||
/** | ||
* @param {!Window} global | ||
* @param {!Object} data | ||
*/ | ||
export function adstyle(global, data) { | ||
validateData(data, ['widget']); | ||
|
||
global._adstyle = global._adstyle || { | ||
viewId: global.context.pageViewId, | ||
widgetIds: [], | ||
referrer: global.context.referrer, | ||
url: global.context.canonicalUrl, | ||
source: global.context.sourceUrl, | ||
}; | ||
|
||
global._adstyle.widgetIds.push(data.widget); | ||
|
||
const url = 'https://widgets.ad.style/amp.js'; | ||
|
||
window.context.observeIntersection(function(changes) { | ||
changes.forEach(function(c) { | ||
window['intersectionRect' + data.widget] = c.intersectionRect; | ||
window['boundingClientRect' + data.widget] = c.boundingClientRect; | ||
}); | ||
}); | ||
|
||
loadScript(global, url); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<!--- | ||
Copyright 2019 The AMP HTML Authors. All Rights Reserved. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS-IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
|
||
# AdStyle | ||
|
||
## Example | ||
|
||
### Basic | ||
|
||
```html | ||
<amp-embed width="400" height="260" | ||
type="adstyle" | ||
heights="(max-width: 320px) 933px, | ||
(max-width: 360px) 1087px, | ||
(max-width: 375px) 1138px, | ||
(max-width: 412px) 1189px, | ||
(max-width: 414px) 1072px, | ||
(max-width: 568px) 1151px, | ||
(max-width: 640px) 1128px, | ||
(max-width: 667px) 1151px, | ||
(max-width: 732px) 1211px, | ||
(max-width: 736px) 1151px, | ||
(max-width: 768px) 633px, | ||
(max-width: 1024px) 711px, | ||
86vw" | ||
data-widget="12345"> | ||
<div placeholder="">Loading ...</div> | ||
</amp-embed> | ||
``` | ||
|
||
## Configuration | ||
|
||
For details on the configuration semantics, please contact the ad network or refer to their documentation. | ||
|
||
### Required parameters | ||
|
||
- `data-widget` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your not using renderStart here, we recommend implementing it if possible, should help with UX and get some performance gains. It is optional.