Create amp-ad-custom.md. #24277
Closed
Create amp-ad-custom.md. #24277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
requested changes
Sep 13, 2019
|
|
||
| ## Ad server | ||
|
|
||
| The ad network needs to provide a new serving endpoint that returns an AMP CORS response in a JSON format: |
There was a problem hiding this comment.
AMP CORS is deprecated. Here we only need CORS
|
|
||
| ```js | ||
| { | ||
| templateUrl: “https://adexample.com/amp_template_1.html” |
There was a problem hiding this comment.
please replace all the “ & ” to "
| - custom headers for AMP CORS (obsolete, just do regular CORS) | ||
| - AMP-Ad-Template-Extension: amp-mustache | ||
| - Amp-Ad-Response-Type: template | ||
| - Access-Control-Expose-Headers: AMP-Access-Control-Allow-Source-Origin |
There was a problem hiding this comment.
AMPCORS has been deprecated, this header is not needed.
| ``` | ||
|
|
||
| The response requires a couple of custom headers: | ||
| - custom headers for AMP CORS (obsolete, just do regular CORS) |
There was a problem hiding this comment.
only regular CORS needed now
|
@rsimha was it deleted accidentally? |
Yes, accidental delete during main repo cleanup. Restored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for amp-ad-custom integration.