馃悰Story Ads: fix dependency #24278
Merged
馃悰Story Ads: fix dependency #24278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #24281 |
erwinmombay
approved these changes
Aug 29, 2019
newmuis
pushed a commit
that referenced
this pull request
Aug 30, 2019
calebcordry
added a commit
that referenced
this pull request
Aug 30, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-story-auto-ads is importing a function from amp-ad-exit to validate config. In PR #24044 I added this specific file, but should have been a glob.
This showed up as
FilterType$$module$extensions$amp_ad_exit$0_1$filters$filter is not definedin canarySide note: this worked when testing with
gulp dist --fortesting && gulp serve --compilednot sure why it wasn't broken. @erwinmombay Do you know of a better way I can test?