馃悰Experiment flag to use amp-carousel 0.2 in amp-lightbox-gallery #24324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix programmatic scroll not working after the user swiped by correctly clearing the `actionSource` flag. - Fix carousel selector for applying `object-fit: contain`, the class was renamed earlier. - Remove old logic for amp-base-carousel experiment in amp-lightbox-gallery. - Remove logic for stopping propagation on carousel touchmove events. The carousel 0.1 version of this only worked for type="carousel" and not type="slides". This prevents swipe to dismiss in the lightbox from working.
|
(waiting for travis on this) |
|
Fixed a few things, Travis is now passing. |
wassgha
approved these changes
Sep 23, 2019
|
Is this experiment still needed? Someone was puzzled seeing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to launch amp-carousel 0.2 for use from amp-lightbox-gallery to fix a few outstanding bugs with carousel in the lightbox. This creates an experiment flag for using the new version of carousel. Note that the version of the carousel declared on the page has preference, so if it is using 0.1, this change will have no effect.
clearing the
actionSourceflag.object-fit: contain, the class wasrenamed earlier.
carousel 0.1 version of this only worked for type="carousel" and not
type="slides". This prevents swipe to dismiss in the lightbox from working.
Fixes #24627