馃敟馃悰update yahoonativeads script and example [amp-embed type=yahoonativeads] #24330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dysfunc
changed the title
|
@calebcordry :) please |
calebcordry
reviewed
Sep 5, 2019
| }); | ||
| }); | ||
| global.apiKey = data.key; | ||
| global.publisherUrl = data.url; |
There was a problem hiding this comment.
I can't see your JS but one thing we generally recommend is to make sure you URL encode these values before trying to send requests.
There was a problem hiding this comment.
To be clear - I mean doing this in your external JS if it's not already there.
There was a problem hiding this comment.
glad you're calling that out in PRs 馃憤
calebcordry
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the current
yahoonativeadsad integrationnative.js