Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story consent interactive tests. #24396

Merged

Conversation

gmajoulet
Copy link
Contributor

Adding accept/reject story consent interactive tests.

@Enriqe
Copy link
Contributor

Enriqe commented Sep 6, 2019

All I see in the percy diffs is black screens... is this WAI?

@gmajoulet
Copy link
Contributor Author

Yes that's because the consent is hidden after being accepted/rejected

Copy link
Contributor

@Enriqe Enriqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh makes sense, thanks!

@Enriqe Enriqe merged commit 51cf076 into ampproject:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants