Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ noContent on destroy Nativeroll player #24427

Merged
merged 1 commit into from Oct 2, 2019
Merged

✨ noContent on destroy Nativeroll player #24427

merged 1 commit into from Oct 2, 2019

Conversation

n-randin
Copy link
Contributor

Adding new callback onDestroy in our player and call 'noContentAvailable' on it

@n-randin
Copy link
Contributor Author

@lannka Check that pls for merge

@n-randin n-randin changed the title ✨ noContent on destroy player ✨ noContent on destroy Nativeroll player Sep 12, 2019
@n-randin
Copy link
Contributor Author

@lannka Hm, branch don't merge automaticaly in this time. Can u merge this pls?

@n-randin
Copy link
Contributor Author

@lannka When you can merge this branch? Or do i need to create another pullrequest or something?

@lannka lannka merged commit f475341 into ampproject:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka Awaiting requested review from lannka

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@n-randin @lannka @googlebot