amp-selector: "select" event should have variable trust #24431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I mentioned in #24425 (comment), we should give a deprecation warning and lead time (6 weeks), even though this is a bug. |
sparhami
suggested changes
Sep 10, 2019
7 tasks
|
Is this safe to merge yet? Looks like the #24443 has been open nearly 6 weeks, not including time to release in prod. |
sparhami
approved these changes
Oct 21, 2019
added 2 commits
October 21, 2019 16:41
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…4431) * amp-selector 'select' should have variable trust. * Propagate trust instead of setting to low. * Add user warning. * Should be <.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24425 and closes #24443.
Note: do not submit until deprecation notice period is over in mid-October.
/to @sparhami