Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ix.md #24459

Merged
merged 1 commit into from Sep 18, 2019
Merged

Conversation

rimaburder-index
Copy link
Contributor

Instructions:

  • Pick a meaningful title for your pull request. (Use sentence case.)
    • Prefix the title with an emoji to identify what is being done. (Copy-paste the emoji itself (not the :code:) from the list below.)
    • Do not overuse punctuation in the title (like (chore):).
    • If it is helpful, use a simple prefix (like ProjectX: Implement some feature).
  • Enter a succinct description that says why the PR is necessary, and what it does.
    • Mention the GitHub issue that is being addressed by the pull request.
    • The keywords Fixes, Closes, or Resolves followed the issue number will automatically close the issue.

Example of a good description:

  • Implement aspect X
  • Leave out feature Y because of A
  • Improve performance by B
  • Improve accessibility by C

Emojis for categorizing pull requests:

โœจ New feature (:sparkles:)
๐Ÿ› Bug fix (:bug:)
๐Ÿ”ฅ P0 fix (:fire:)
โœ… Tests (:white_check_mark:)
๐Ÿš€ Performance improvements (:rocket:)
๐Ÿ– CSS / Styling (:crayon:)
โ™ฟ Accessibility (:wheelchair:)
๐ŸŒ Internationalization (:globe_with_meridians:)
๐Ÿ“– Documentation (:book:)
๐Ÿ— Infrastructure / Tooling / Builds / CI (:building_construction:)
โช Reverting a previous change (:rewind:)
โ™ป๏ธ Refactoring (like moving around code w/o any changes) (:recycle:)
๐Ÿšฎ Deleting code (:put_litter_in_its_place:)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

๐Ÿ“ Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

โ„น๏ธ Googlers: Go here for more info.

@zhouyx
Copy link
Contributor

zhouyx commented Sep 17, 2019

to @lannka to reassign.

@zhouyx zhouyx requested a review from lannka September 17, 2019 22:35
@lannka lannka merged commit 73f3219 into ampproject:master Sep 18, 2019
@rimaburder-index
Copy link
Contributor Author

rimaburder-index commented Sep 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants