Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make amp-list[diffable] valid #24467

Merged
merged 2 commits into from Sep 11, 2019
Merged

Make amp-list[diffable] valid #24467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fbd01a
Make amp-list[diffable] valid.
Sep 11, 2019
d04b7a1
David's comment.
Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions extensions/amp-list/0.1/test/validator-amp-list.html
View file
Open in desktop
Expand Up @@ -126,6 +126,11 @@
src="https://data.com/articles.json?ref=CANONICAL_URL"
[is-layout-container]="containerState"></amp-list>
</amp-list>
<!-- Valid amp-list with [diffable] attribute -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, use quote or quotes instead of brackets since brackets may be amp-bind attributes and this isn't one of those: <-- Valid amp-list with 'diffable' attribute -->

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the brackets to be consistent with the rest of file. 👍

<amp-list width=10 height=10
src="https://data.com/articles.json?ref=CANONICAL_URL"
diffable></amp-list>
</amp-list>
<!-- Invalid: unsupported "binding" attribute value -->
<amp-list width=10 height=10
src="https://data.com/articles.json?ref=CANONICAL_URL"
Expand Down
35 changes: 20 additions & 15 deletions extensions/amp-list/0.1/test/validator-amp-list.out
View file
Open in desktop
Expand Up @@ -131,72 +131,77 @@ amp-list/0.1/test/validator-amp-list.html:85:2 The attribute 'auto-resize' in ta
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| [is-layout-container]="containerState"></amp-list>
| </amp-list>
| <!-- Valid amp-list with [diffable] attribute -->
| <amp-list width=10 height=10
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| diffable></amp-list>
| </amp-list>
| <!-- Invalid: unsupported "binding" attribute value -->
| <amp-list width=10 height=10
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:130:2 The attribute 'binding' in tag 'amp-list' is set to the invalid value 'this-is-an-error'. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:135:2 The attribute 'binding' in tag 'amp-list' is set to the invalid value 'this-is-an-error'. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| binding="this-is-an-error">
| <div></div>
| </amp-list>
| <!-- Invalid: width is mistyped. -->
| <amp-list src="https://data.com/articles.json?ref=CANONICAL_URL"
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:136:2 The attribute 'wdith' may not appear in tag 'amp-list'. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:141:2 The attribute 'wdith' may not appear in tag 'amp-list'. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
| wdith=10 height=10>
| <div></div>
| </amp-list>
| <!-- Invalid: missing at least src or [src]. -->
| <amp-list width=10 height=10>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:141:2 The tag 'amp-list' is missing a mandatory attribute - pick at least one of ['src','[src]']. (see https://amp.dev/documentation/components/amp-list) [AMP_TAG_PROBLEM]
amp-list/0.1/test/validator-amp-list.html:146:2 The tag 'amp-list' is missing a mandatory attribute - pick at least one of ['src','[src]']. (see https://amp.dev/documentation/components/amp-list) [AMP_TAG_PROBLEM]
| <div></div>
| </amp-list>
| <!-- Invalid: width/height missing, so it's container layout
| which isn't supported. -->
| <amp-list src="https://data.com/articles.json?ref=CANONICAL_URL">
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:146:2 Incomplete layout attributes specified for tag 'amp-list'. For example, provide attributes 'width' and 'height'. (see https://amp.dev/documentation/components/amp-list) [AMP_LAYOUT_PROBLEM]
amp-list/0.1/test/validator-amp-list.html:151:2 Incomplete layout attributes specified for tag 'amp-list'. For example, provide attributes 'width' and 'height'. (see https://amp.dev/documentation/components/amp-list) [AMP_LAYOUT_PROBLEM]
| <div></div>
| </amp-list>
| <!-- Invalid amp-list with load-more attribute -->
| <amp-list width=10 height=10
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:150:2 The attribute 'load-more' in tag 'amp-list' is set to the invalid value ''. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:155:2 The attribute 'load-more' in tag 'amp-list' is set to the invalid value ''. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| load-more></amp-list>
| </amp-list>
| <!-- Invalid amp-list with bad load-more attribute -->
| <amp-list width=10 height=10
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:155:2 The attribute 'load-more' in tag 'amp-list' is set to the invalid value 'gibberish'. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:160:2 The attribute 'load-more' in tag 'amp-list' is set to the invalid value 'gibberish'. (see https://amp.dev/documentation/components/amp-list) [DISALLOWED_HTML]
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| load-more="gibberish"
| load-more-bookmark="next"></amp-list>
| </amp-list>
| <!-- Invalid load-more attributes -->
| <div load-more-button></div>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:161:2 The attribute 'load-more-button' may not appear in tag 'div'. [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:166:2 The attribute 'load-more-button' may not appear in tag 'div'. [DISALLOWED_HTML]
| <div load-more-loading></div>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:162:2 The attribute 'load-more-loading' may not appear in tag 'div'. [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:167:2 The attribute 'load-more-loading' may not appear in tag 'div'. [DISALLOWED_HTML]
| <div load-more-failed></div>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:163:2 The attribute 'load-more-failed' may not appear in tag 'div'. [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:168:2 The attribute 'load-more-failed' may not appear in tag 'div'. [DISALLOWED_HTML]
| <div load-more-end></div>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:164:2 The attribute 'load-more-end' may not appear in tag 'div'. [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:169:2 The attribute 'load-more-end' may not appear in tag 'div'. [DISALLOWED_HTML]
| <amp-list-load-more></amp-list-load-more>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:165:2 The parent tag of tag 'amp-list-load-more' is 'body', but it can only be 'amp-list'. (see https://amp.dev/documentation/components/amp-list) [AMP_TAG_PROBLEM]
amp-list/0.1/test/validator-amp-list.html:170:2 The parent tag of tag 'amp-list-load-more' is 'body', but it can only be 'amp-list'. (see https://amp.dev/documentation/components/amp-list) [AMP_TAG_PROBLEM]
| <amp-list width=10 height=10
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| load-more="manual"
| load-more-bookmark="next">
| <button load-more-clickable></button>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:170:4 The parent tag of tag 'amp-list-load-more button[load-more-clickable]' is 'amp-list', but it can only be 'amp-list-load-more'. (see https://amp.dev/documentation/components/amp-list) [AMP_TAG_PROBLEM]
amp-list/0.1/test/validator-amp-list.html:175:4 The parent tag of tag 'amp-list-load-more button[load-more-clickable]' is 'amp-list', but it can only be 'amp-list-load-more'. (see https://amp.dev/documentation/components/amp-list) [AMP_TAG_PROBLEM]
| </amp-list>
| <amp-list width=10 height=10
| src="https://data.com/articles.json?ref=CANONICAL_URL"
Expand All @@ -207,7 +212,7 @@ amp-list/0.1/test/validator-amp-list.html:170:4 The parent tag of tag 'amp-list-
| <!-- References to template elements -->
| <amp-list width=10 height=10
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:179:2 Attribute 'template' in tag 'amp-list' contains a value that does not match any other tags on the page. (see https://amp.dev/documentation/components/amp-list) [GENERIC]
amp-list/0.1/test/validator-amp-list.html:184:2 Attribute 'template' in tag 'amp-list' contains a value that does not match any other tags on the page. (see https://amp.dev/documentation/components/amp-list) [GENERIC]
| src="https://data.com/articles.json?ref=CANONICAL_URL"
| template="missing">
| <div></div>
Expand All @@ -219,8 +224,8 @@ amp-list/0.1/test/validator-amp-list.html:179:2 Attribute 'template' in tag 'amp
| </amp-list>
| <template id="found"></template>
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:189:2 The mandatory attribute 'type' is missing in tag 'template'. (see https://amp.dev/documentation/components/amp-mustache) [DISALLOWED_HTML]
amp-list/0.1/test/validator-amp-list.html:194:2 The mandatory attribute 'type' is missing in tag 'template'. (see https://amp.dev/documentation/components/amp-mustache) [DISALLOWED_HTML]
>> ^~~~~~~~~
amp-list/0.1/test/validator-amp-list.html:189:2 The tag 'template' requires including the 'amp-mustache' extension JavaScript. (see https://amp.dev/documentation/components/amp-mustache) [MANDATORY_AMP_TAG_MISSING_OR_INCORRECT]
amp-list/0.1/test/validator-amp-list.html:194:2 The tag 'template' requires including the 'amp-mustache' extension JavaScript. (see https://amp.dev/documentation/components/amp-mustache) [MANDATORY_AMP_TAG_MISSING_OR_INCORRECT]
| </body>
| </html>
4 changes: 4 additions & 0 deletions extensions/amp-list/validator-amp-list.protoascii
View file
Open in desktop
Expand Up @@ -64,6 +64,10 @@ tags: { # <amp-list> with mandatory src and/or [src] attr
value: "refresh"
}
attrs: { name: "credentials" }
attrs: {
name: "diffable"
value: ""
}
attrs: { name: "items" }
attrs: {
name: "load-more"
Expand Down