Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毊Cleanup for the new loaders. #24571

Merged
merged 2 commits into from Sep 24, 2019
Merged

Conversation

sparhami
Copy link

  • Remove the legacy loaders code and CSS.
  • Remove experiment checks and flags.
  • Reword references to the "new" loader.

Closes #21485

- Remove the legacy loaders code and CSS.
- Remove experiment checks and flags.
- Reword references to the "new" loader.
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the a4a issue is addressed, everything else looks good!

extensions/amp-ad/0.1/amp-ad-ui.js Show resolved Hide resolved
@sparhami sparhami marked this pull request as ready for review September 19, 2019 18:31
@sparhami
Copy link
Author

Waiting for the next canary to be cut before submitting this change, so that we have had enough time with the new loaders code launched and we are confident that we do not need to disable the experiment.

@sparhami sparhami merged commit 2e9a940 into ampproject:master Sep 24, 2019
@sparhami sparhami deleted the loaders_cleanup branch September 24, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup new-loaders experiments
3 participants