馃彈 Updates existing OWNERS.yaml files with brace-set and modifier syntax1 #24599
Conversation
rcebulko
changed the title
rcebulko
requested review from
rsimha and
cramforce
and removed request for
rsimha
| - ampproject/wg-infra | ||
| - ampproject/wg-runtime | ||
| - ampproject/wg-performance | ||
| - "**/OWNERS.yaml": "#rcebulko" |
There was a problem hiding this comment.
Is this giving you the power to change all owners?
There was a problem hiding this comment.
The idea behind this was that it would be here only temporarily during this transition period where many owners files are being updated as contributors and teams notice which files are out of date. The # will tag me on any PR that touches an owners file, so I can verify syntax and semantics of all updates until I finish the syntax check API for Travis to use (which would ideally happen this week but since I'm build-cop this week it depends).
Technically speaking, it means I could theoretically make myself an owner of something (I will not). Practically speaking, I do not have merge access on this repository (so someone else would have to actually review and merge it anyway), the owners bot is non-blocking currently, and I run and maintain the actual owners bot itself, so from a security perspective it seemed moot. I will remove if you'd prefer.
There was a problem hiding this comment.
The idea behind this was that it would be here only temporarily during this transition period where many owners files are being updated as contributors and teams notice which files are out of date. The # will tag me on any PR that touches an owners file, so I can verify syntax and semantics of all updates until I finish the syntax check API for Travis to use (which would ideally happen this week but since I'm build-cop this week it depends).
Technically speaking, it means I could theoretically make myself an owner of something (I will not). Practically speaking, I do not have merge access on this repository (so someone else would have to actually review and merge it anyway), the owners bot is non-blocking currently, and I run and maintain the actual owners bot itself, so from a security perspective it seemed moot. I will remove if you'd prefer.
There was a problem hiding this comment.
Please paste a version of this comment as a comment into the yaml file.
There was a problem hiding this comment.
One more thing (sorry), please also create and add here an issue for cleanup.
There was a problem hiding this comment.
Done! Created #24685 and added a TODO here.
| - ampproject/wg-infra | ||
| - ampproject/wg-runtime | ||
| - ampproject/wg-performance | ||
| - "**/OWNERS.yaml": "#rcebulko" |
There was a problem hiding this comment.
One more thing (sorry), please also create and add here an issue for cleanup.
Upgrades to the owners bot parser include support for brace-set expansion, ie
*.{js,css}. This PR updates currently-duplicated rules to use this syntax.