Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for the SHE Media ad network. #24602

Merged
merged 3 commits into from Sep 19, 2019

Conversation

mgriego
Copy link
Contributor

@mgriego mgriego commented Sep 18, 2019

Adds support for members of the SHE Media Partner Network to serve SHE Media ads on their AMP pages.

/cc @lannka @zhouyx

@mgriego
Copy link
Contributor Author

mgriego commented Sep 18, 2019

Hey all,
I don't think the failed tests are related to my code. The saucelabs check failed trying to run a Firefox test:

[15:03:02] Firefox 70.0.0 (Windows 10.0.0): STARTED
[15:03:02] ERROR: Zero tests detected by Karma.
[15:03:02] {"startTime":1568818982951,"total":0,"success":0,"failed":0,"skipped":0,"totalTime":1,"netTime":0,"error":true,"disconnected":false}

The Percy test failed on some consent issues. These updates should not have affected any of the core consent logic, so I think the failure is unrelated to this PR.

@mgriego
Copy link
Contributor Author

mgriego commented Sep 18, 2019

Rebased it on the current upstream master to see if that fixes the Percy test.

@mgriego
Copy link
Contributor Author

mgriego commented Sep 19, 2019

@alanorozco Can you help with the tests here? I don't have permissions to restart the test jobs, and the Sauce Labs job is repeatedly failing with issues during the Firefox test.

@mrjoro
Copy link
Member

mrjoro commented Sep 19, 2019

/cc @ampproject/wg-ads

@mgriego
Copy link
Contributor Author

mgriego commented Sep 19, 2019

/cc @calebcordry

@lannka lannka merged commit f0119a5 into ampproject:master Sep 19, 2019
@mgriego mgriego deleted the pmc-shemedia-ad-network branch September 20, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants