New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Follow up changes to integration tests on sauce labs #24623
Conversation
I was going to merge in a hurry to unblock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on my PR. I think it's cool to bubble up the test status of beta browsers, esp since these checks are non blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! Feedback addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest comment addressed. If you think there's a better way to do this, I'm happy to abandon this PR in favor of the one you started. (I mistakenly thought this was blocking master
yesterday and tried putting together a quick fix.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Eventually we wanted to make these test statuses blocking, so we'll have to make an exception in the test-status app to mark failing |
Good point. Github allows us to make a subset of the test status checks blocking. So we can make all but the |
Highlights:
integration/saucelabs
test status intointegration/saucelabs-stable
andintegration/saucelabs-beta
Fixes this error:
Follow up to #24613