New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip flaky story analytics integration tests #24638
Conversation
Looks like flakiness is just on Chrome 77.0.3865 (Windows 10.0.0) FYI. |
Do we have a "skip windows" test option? |
That's true, unfortunately I don't think there is a "skip windows" test option |
We can add one. ;) |
Wait no, I removed Also I was looking at these tests just now, I'm not sure the OS is the reason for the flakiness. |
test/_init_tests.js
Outdated
@@ -148,6 +149,10 @@ class TestConfig { | |||
return this.skip(this.runOnIos); | |||
} | |||
|
|||
skipWindows() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
Alright I reverted the last commit which introduces the skip for windows. Let's just skip them |
Good point, what we want is to skip Chrome on Windows specifically. Either way. |
They are flaking on master
https://travis-ci.org/ampproject/amphtml/jobs/587116429
https://travis-ci.org/ampproject/amphtml/jobs/587121381
/cc @choumx