Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 Rephrase how lightbox-gallery disables auto-lightbox #24642

Merged
merged 2 commits into from Sep 19, 2019
Merged

馃摉 Rephrase how lightbox-gallery disables auto-lightbox #24642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02ce727
馃摉 Rephrase how lightbox-gallery disables auto-lightbox
alanorozco Sep 19, 2019
616b827
Update auto-lightbox.md
alanorozco Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions spec/auto-lightbox.md
View file
Open in desktop
Expand Up @@ -4,11 +4,12 @@ The standard AMP runtime finds elligible [`amp-img`](https://amp.dev/documentati
elements and automatically makes them clickable in order to open an [`amp-lightbox-gallery`](https://amp.dev/documentation/components/amp-lightbox-gallery)
for enhanced user experience that includes panning and pinch-to-zoom.

Documents that explicitly use `amp-lightbox-gallery` are excluded from this treatment.
Including the [`amp-lightbox-gallery` extension script](https://amp.dev/documentation/components/amp-lightbox-gallery/) and [using it explicitly](https://amp.dev/documentation/components/amp-lightbox-gallery/#usage) (by setting the `lightbox` attribute on a valid element) disables the auto-lightbox treatment on a document.

Otherwise, it's applied only on documents that contain either of the following:

- an [OpenGraph](http://ogp.me/) `<meta property="og:type" content="article">` tag
- or a `@type` field declared in [JSON+LD schema](https://amp.dev/documentation/guides-and-tutorials/optimize-and-measure/discovery#use-schema.org-for-most-search-engines)
- **a.** an [OpenGraph](http://ogp.me/) `<meta property="og:type" content="article">` tag
- **b.** ...or a `@type` field declared in [JSON+LD schema](https://amp.dev/documentation/guides-and-tutorials/optimize-and-measure/discovery#use-schema.org-for-most-search-engines)
that's any of the following:
- `Article`
- `NewsArticle`
Expand Down