🏗 Make nailgun
server stoppage a time-bound operation and log errors if any
#24648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that the operation to stop the nailgun server after
gulp dist
occasionally causes Travis builds to stall. Since this is a non-essential cleanup step, it makes sense to make the operation time-bound and non-blocking.This PR implements the idea in #24487 (comment) and gives the process 5 seconds to execute before printing a warning and continuing.
Reference: See the
timeout
option ofchild_process.spawnSync()
Potential fix for #24487