Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Reduce gulp dist parallelism on Travis, add some logging #24662

Merged
merged 7 commits into from Oct 2, 2019
Merged

🏗 Reduce gulp dist parallelism on Travis, add some logging #24662

merged 7 commits into from Oct 2, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Sep 20, 2019

Still trying to figure out why gulp dist occasionally stalls on Travis. Tried a few things listed in #24487.

Next steps in this PR:

  • Reduce parallelism for multi-pass gulp dist to 1 (doesn't make a substantial difference to running time)
  • Add logging + timing for buildExtensions() and compileAllJs() (so we know when all promises have resolved)
  • Fix bug in timing each minification step (we were counting queued time instead of running time, and weren't including the minutes value for longer tasks)

See #24487 (comment)

Potential fix for #24487

@rsimha
Copy link
Contributor Author

rsimha commented Sep 20, 2019

Running time of gulp dist without parallel invocations of closure is ~11 min, which is not too different from earlier. I'd like to merge this and see what effect it has on the stalled builds in #24487 we're trying to fix.

@rsimha
Copy link
Contributor Author

rsimha commented Oct 2, 2019

Dusted off this old PR and made a couple of changes.

  • Reduce parallelism only for multi-pass build (this is where parallelism might have been causing a stall)
  • Fix minification step timing bug

Adding @danielrozenberg for review

@rsimha rsimha merged commit 5b0db7a into ampproject:master Oct 2, 2019
@rsimha rsimha deleted the 2019-09-20-DistParallelism branch October 2, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants