Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade DOMPurify to 2.0.2 #24681

Merged
merged 1 commit into from Sep 23, 2019
Merged

Upgrade DOMPurify to 2.0.2 #24681

merged 1 commit into from Sep 23, 2019

Conversation

dreamofabear
Copy link

Upgrade past 2.0.1 for this:

Fixed a bypass affecting latest Chrome, caused by a newly discovered Chrome mXSS vulnerability

Not sure why renovate-bot didn't generate the PRs for 2.x.x.

https://github.com/cure53/DOMPurify/releases

@dreamofabear
Copy link
Author

/to @rsimha

rsimha
rsimha approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why renovate-bot didn't generate the PRs for 2.x.x.

We currently disable automatic upgrades for all core runtime dependencies. See #23008. Easy to change this if necessary.

amphtml/renovate.json

Lines 12 to 14 in 397052d

"dependencies": {
"enabled": false
},

@dreamofabear dreamofabear merged commit c6f588b into ampproject:master Sep 23, 2019
@dreamofabear dreamofabear deleted the dompurify-2.0.2 branch September 23, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dreamofabear @rsimha @googlebot