Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 amp-ad type blade - fix bladeOnLoad callback #24683

Merged
merged 1 commit into from Oct 1, 2019
Merged

馃悰 amp-ad type blade - fix bladeOnLoad callback #24683

merged 1 commit into from Oct 1, 2019

Conversation

gershman
Copy link
Contributor

  • fix bladeOnLoad callback function
  • fix bladeConfig

@gershman
Copy link
Contributor Author

gershman commented Sep 23, 2019 •
edited

@mrjoro, @lannka Hi, can you review this?

@mrjoro
Copy link
Member

mrjoro commented Sep 24, 2019

Let's see if #addowners works. (This is a new bot that should add reviewers automatically...)

@mrjoro mrjoro requested a review from lannka September 24, 2019 16:25
@mrjoro
Copy link
Member

mrjoro commented Sep 24, 2019

It looks like it didn't work to add reviewers automatically, so I've added @lannka as a reviewer and /cc @ampproject/wg-ads.

@calebcordry calebcordry self-requested a review October 1, 2019 16:58
calebcordry
calebcordry approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing maintenance of this integration!

@calebcordry calebcordry merged commit f69d65e into ampproject:master Oct 1, 2019
@gershman gershman deleted the amp-ad--blade-fix-onplayerload branch October 2, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

@lannka lannka Awaiting requested review from lannka

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gershman @mrjoro @calebcordry @googlebot