Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Update amp-autocomplete documentation #24689

Merged
merged 2 commits into from Sep 23, 2019

Conversation

caroqliu
Copy link
Contributor

Resolves #24684

The < and > tags around <amp-autocomplete> in the documentation render the component on its documentation page instead of displays it as the desired text literal. This causes the section to end mid-sentence on the amp.dev:
Screen Shot 2019-09-23 at 11 15 17 AM

@caroqliu caroqliu merged commit 141b25c into ampproject:master Sep 23, 2019
@caroqliu caroqliu deleted the autocomplete-documentation branch September 23, 2019 19:57
@rcebulko
Copy link
Contributor

@caroqliu @wassgha I noticed this PR was submitted without owners approval. Should an OWNERS.yaml file be added to amp-autocomplete?

For reference, see the current owners tree

@caroqliu
Copy link
Contributor Author

@rcebulko Thanks for checking in on this! Looks like it was recently updated with the appropriate owners, so should be good going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisible text in amp-autocomplete documentation
4 participants