Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Add comment to the top of every OWNERS file #24693

Merged
merged 3 commits into from Sep 24, 2019

Conversation

rcebulko
Copy link
Contributor

Adds a comment to every OWNERS.yaml file with a link to the example file.
Closes ampproject/amp-github-apps#282

@amp-owners-bot
Copy link

Hey @rcebulko, these files were changed:

  • OWNERS.yaml
  • ads/OWNERS.yaml
  • ads/google/OWNERS.yaml
  • build-system/OWNERS.yaml
  • build-system/global-configs/OWNERS.yaml
  • contributing/OWNERS.yaml
  • css/OWNERS.yaml
  • examples/OWNERS.yaml
  • examples/visual-tests/OWNERS.yaml
  • extensions/OWNERS.yaml
  • extensions/amp-3d-gltf/OWNERS.yaml
  • extensions/amp-3q-player/OWNERS.yaml
  • extensions/amp-a4a/OWNERS.yaml
  • extensions/amp-access-scroll/OWNERS.yaml
  • extensions/amp-access/OWNERS.yaml
  • extensions/amp-accordion/OWNERS.yaml
  • extensions/amp-action-macro/OWNERS.yaml
  • extensions/amp-ad-custom/OWNERS.yaml
  • extensions/amp-ad-exit/OWNERS.yaml
  • extensions/amp-ad-network-adsense-impl/OWNERS.yaml
  • extensions/amp-ad-network-adzerk-impl/OWNERS.yaml
  • extensions/amp-ad-network-cloudflare-impl/OWNERS.yaml
  • extensions/amp-ad-network-doubleclick-impl/OWNERS.yaml
  • extensions/amp-ad-network-fake-impl/OWNERS.yaml
  • extensions/amp-ad-network-gmossp-impl/OWNERS.yaml
  • extensions/amp-ad-network-triplelift-impl/OWNERS.yaml
  • extensions/amp-ad/OWNERS.yaml
  • extensions/amp-addthis/OWNERS.yaml
  • extensions/amp-analytics/OWNERS.yaml
  • extensions/amp-anim/OWNERS.yaml

Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a slight re-wording. Approving to unblock.

OWNERS.yaml Outdated
@@ -1,3 +1,7 @@
# PLEASE DO NOT REMOVE - For an explanation of the OWNERS.yaml rules and syntax,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the PLEASE DO NOT REMOVE is distracting. WDYT about re-wording the comment to the following?

# For an explanation of the OWNERS.yaml rules and syntax, see:
# https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example.yaml

@amp-owners-bot
Copy link

Hey @rcebulko, these files were changed:

  • OWNERS.yaml
  • ads/OWNERS.yaml
  • ads/google/OWNERS.yaml
  • build-system/OWNERS.yaml
  • build-system/global-configs/OWNERS.yaml
  • contributing/OWNERS.yaml
  • css/OWNERS.yaml
  • examples/OWNERS.yaml
  • examples/visual-tests/OWNERS.yaml
  • extensions/OWNERS.yaml
  • extensions/amp-3d-gltf/OWNERS.yaml
  • extensions/amp-3q-player/OWNERS.yaml
  • extensions/amp-a4a/OWNERS.yaml
  • extensions/amp-access-scroll/OWNERS.yaml
  • extensions/amp-access/OWNERS.yaml
  • extensions/amp-accordion/OWNERS.yaml
  • extensions/amp-action-macro/OWNERS.yaml
  • extensions/amp-ad-custom/OWNERS.yaml
  • extensions/amp-ad-exit/OWNERS.yaml
  • extensions/amp-ad-network-adsense-impl/OWNERS.yaml
  • extensions/amp-ad-network-adzerk-impl/OWNERS.yaml
  • extensions/amp-ad-network-cloudflare-impl/OWNERS.yaml
  • extensions/amp-ad-network-doubleclick-impl/OWNERS.yaml
  • extensions/amp-ad-network-fake-impl/OWNERS.yaml
  • extensions/amp-ad-network-gmossp-impl/OWNERS.yaml
  • extensions/amp-ad-network-triplelift-impl/OWNERS.yaml
  • extensions/amp-ad/OWNERS.yaml
  • extensions/amp-addthis/OWNERS.yaml
  • extensions/amp-analytics/OWNERS.yaml
  • extensions/amp-anim/OWNERS.yaml

1 similar comment
@amp-owners-bot
Copy link

Hey @rcebulko, these files were changed:

  • OWNERS.yaml
  • ads/OWNERS.yaml
  • ads/google/OWNERS.yaml
  • build-system/OWNERS.yaml
  • build-system/global-configs/OWNERS.yaml
  • contributing/OWNERS.yaml
  • css/OWNERS.yaml
  • examples/OWNERS.yaml
  • examples/visual-tests/OWNERS.yaml
  • extensions/OWNERS.yaml
  • extensions/amp-3d-gltf/OWNERS.yaml
  • extensions/amp-3q-player/OWNERS.yaml
  • extensions/amp-a4a/OWNERS.yaml
  • extensions/amp-access-scroll/OWNERS.yaml
  • extensions/amp-access/OWNERS.yaml
  • extensions/amp-accordion/OWNERS.yaml
  • extensions/amp-action-macro/OWNERS.yaml
  • extensions/amp-ad-custom/OWNERS.yaml
  • extensions/amp-ad-exit/OWNERS.yaml
  • extensions/amp-ad-network-adsense-impl/OWNERS.yaml
  • extensions/amp-ad-network-adzerk-impl/OWNERS.yaml
  • extensions/amp-ad-network-cloudflare-impl/OWNERS.yaml
  • extensions/amp-ad-network-doubleclick-impl/OWNERS.yaml
  • extensions/amp-ad-network-fake-impl/OWNERS.yaml
  • extensions/amp-ad-network-gmossp-impl/OWNERS.yaml
  • extensions/amp-ad-network-triplelift-impl/OWNERS.yaml
  • extensions/amp-ad/OWNERS.yaml
  • extensions/amp-addthis/OWNERS.yaml
  • extensions/amp-analytics/OWNERS.yaml
  • extensions/amp-anim/OWNERS.yaml

@cathyxz cathyxz merged commit caa3bd7 into ampproject:master Sep 24, 2019
@rcebulko rcebulko deleted the owners-comment branch September 24, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[owners] Provide a comment with instructions at the top of every OWNERS.yaml file
4 participants