Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inabox viewport #24700

Merged
merged 2 commits into from Sep 24, 2019
Merged

Fix inabox viewport #24700

merged 2 commits into from Sep 24, 2019

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Sep 24, 2019

Tested locally. The bug should be caught by integration tests on Safari 11 (to be enabled #24666)

This was causing ActiveView issues for BTF ads on browsers that do not support IntersectionObserver

@lannka lannka merged commit 2a78216 into ampproject:master Sep 24, 2019
@lannka lannka deleted the fix-inabox-viewport branch September 24, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants