Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring stories tests to use async/await. #24721

Merged
merged 2 commits into from Sep 26, 2019

Conversation

gmajoulet
Copy link
Contributor

Got an improvement idea while working on #24719 (cf comment inline in that PR code) that would need this, and I got carried away...

@amp-owners-bot
Copy link

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/1.0/test/test-amp-story-bookend.js
  • extensions/amp-story/1.0/test/test-amp-story-consent.js
  • extensions/amp-story/1.0/test/test-amp-story-cta-layer.js
  • extensions/amp-story/1.0/test/test-amp-story-embedded-component.js
  • extensions/amp-story/1.0/test/test-amp-story-info-dialog.js
  • extensions/amp-story/1.0/test/test-amp-story-media-query-service.js
  • extensions/amp-story/1.0/test/test-amp-story-page.js
  • extensions/amp-story/1.0/test/test-amp-story-request-service.js
  • extensions/amp-story/1.0/test/test-amp-story.js
  • extensions/amp-story/1.0/test/test-live-story-manager.js
  • extensions/amp-story/1.0/test/test-media-tasks.js

Hey @newmuis, these files were changed:

  • extensions/amp-story/1.0/test/test-amp-story-bookend.js
  • extensions/amp-story/1.0/test/test-amp-story-consent.js
  • extensions/amp-story/1.0/test/test-amp-story-cta-layer.js
  • extensions/amp-story/1.0/test/test-amp-story-embedded-component.js
  • extensions/amp-story/1.0/test/test-amp-story-info-dialog.js
  • extensions/amp-story/1.0/test/test-amp-story-media-query-service.js
  • extensions/amp-story/1.0/test/test-amp-story-page.js
  • extensions/amp-story/1.0/test/test-amp-story-request-service.js
  • extensions/amp-story/1.0/test/test-amp-story.js
  • extensions/amp-story/1.0/test/test-live-story-manager.js
  • extensions/amp-story/1.0/test/test-media-tasks.js

@wassgha
Copy link
Contributor

wassgha commented Sep 25, 2019

Related to #24076

Copy link
Contributor

@Enriqe Enriqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming no logic change (didn't review test-amp-story.js since it's 1.6k LOC). I also assume you used a tool to do the replace hehe. Thanks for this!

@gmajoulet
Copy link
Contributor Author

I actually did this manually 😭😭

@gmajoulet gmajoulet merged commit dcea229 into ampproject:master Sep 26, 2019
@gmajoulet gmajoulet deleted the stories_tests_async_await branch September 26, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants