Allow amp-experiment to prerender and bypass maximum build limit #24745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
commented
Sep 25, 2019
| 'This is a protected API. Please only override it the element is ' + | ||
| 'render blocking', | ||
| whitelist: [ | ||
| 'src/service/resources-impl.js', |
There was a problem hiding this comment.
Signed... I need to make change to all four files to pass the isRenderBlocking() method from a component to the resource manager...
jridgewell
reviewed
Sep 26, 2019
src/base-element.js
Outdated
| * built _and_ laid out will be prioritized. | ||
| * @return {boolean} | ||
| */ | ||
| isRenderBlocking() { |
There was a problem hiding this comment.
I'd rather this be specific to buildCallback, with "build" somewhere in the name. Having this return true currently doesn't do anything for layoutCallback.
There was a problem hiding this comment.
to confirm, you want me to change the name?
What about isBuildRenderBlocking()?
jridgewell
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we agreed offline, this PR
<amp-experiment>component to prerenderisBuildRenderBlocking()method to bypass the 20 maximum build count