♻️Refactor amp-ad-network-adsense-impl to move logic related to rive to a separate helper class #24759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riklund
force-pushed
the
cleanup-1
branch
3 times, most recently
from
f6dbef8
to
ee1954e
Compare
lannka
approved these changes
Sep 26, 2019
| 'responsive-state', | ||
| { | ||
| amp: { | ||
| extensions: ['amp-ad', 'amp-ad-network-adsense-impl'], |
There was a problem hiding this comment.
i guess you don't need those extensions in this unit test.
| return ( | ||
| !!this.element.getAttribute('data-ad-client') && this.isAmpAdElement() | ||
| (this.responsiveState_ == null || |
There was a problem hiding this comment.
one level of if-else might make the code a bit easier to read here
…ive to a separate helper class.
lannka
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.