Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖Updated rtc-config specification details in IX.md #24761

Merged
merged 1 commit into from Sep 26, 2019

Conversation

rimaburder-index
Copy link
Contributor

Instructions:

  • Pick a meaningful title for your pull request. (Use sentence case.)
    • Prefix the title with an emoji to identify what is being done. (Copy-paste the emoji itself (not the :code:) from the list below.)
    • Do not overuse punctuation in the title (like (chore):).
    • If it is helpful, use a simple prefix (like ProjectX: Implement some feature).
  • Enter a succinct description that says why the PR is necessary, and what it does.
    • Mention the GitHub issue that is being addressed by the pull request.
    • The keywords Fixes, Closes, or Resolves followed the issue number will automatically close the issue.

Example of a good description:

  • Implement aspect X
  • Leave out feature Y because of A
  • Improve performance by B
  • Improve accessibility by C

Emojis for categorizing pull requests:

✨ New feature (:sparkles:)
🐛 Bug fix (:bug:)
🔥 P0 fix (:fire:)
✅ Tests (:white_check_mark:)
🚀 Performance improvements (:rocket:)
🖍 CSS / Styling (:crayon:)
♿ Accessibility (:wheelchair:)
🌐 Internationalization (:globe_with_meridians:)
📖 Documentation (:book:)
🏗 Infrastructure / Tooling / Builds / CI (:building_construction:)
⏪ Reverting a previous change (:rewind:)
♻️ Refactoring (like moving around code w/o any changes) (:recycle:)
🚮 Deleting code (:put_litter_in_its_place:)

@@ -40,18 +40,18 @@ The value of `rtc-config` must conform to the following specification:
            "vendors": {
                "IndexExchange": {"SITE_ID": "123456"},
            },
            "timeoutMillis": 1000'
}
            "timeoutMillis": 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) thanks for looking into this.

@zhouyx zhouyx merged commit 3b85257 into ampproject:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants