Store story page IDs from the buildCallback. #24764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, these files were changed:
Hey @newmuis, these files were changed:
|
newmuis
approved these changes
Sep 26, 2019
gmajoulet
force-pushed
the
store_page_ids_build_callback
branch
from
621e349
to
72011e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store story page IDs from the buildCallback.
Also, updating the tests so the story is created with its pages already in the DOM.
Our previous implementation wasn't optimal: creating and attaching the story from
beforeEachwould triggerbuildCallbackbefore we append the pages.In practice, that means that the timeline was
buildCallback-> appendamp-story-pages ->layoutCallbackand is now
amp-story-pages ->buildCallback->layoutCallback