馃彈 Move smartlinks owners out of version directory #24769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rcebulko, these files were changed:
|
zhouyx
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a general owners cleanup effort.
The existing OWNERS file lives in
extensions/amp-smartlinks/0.1, which means it does not coverA) The
amp-smartlinks.mdandvalidator-amp-smartlinks.protoasciifiles in theextensions/amp-smartlinksdirectoryB) Any future version, ie. a new
extensions/amp-smartlinks/0.2directory would require external owners approvalI'm assuming this is not the intention, so this PR lifts the OWNERS file up to the
extensions/amp-smartlinksdirectory.@zhouyx I don't have merge permissions, so feel free to merge this if/when you approve it.