Add SeedingAlliance support to amp-ad #24795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
requested changes
Oct 1, 2019
examples/ads.amp.html
Outdated
| <amp-ad | ||
| height="250" | ||
| type="seedingalliance" | ||
| data-url="mockup.seeding-alliance.de"> |
There was a problem hiding this comment.
If your backend allows, it would be nice to include the https:// protocol as well if that works. Let me know if you do not, and I can approve.
There was a problem hiding this comment.
That's not a problem, I added the protocol.
powerivq
approved these changes
Oct 2, 2019
|
@SeedingAllianceTech Hey, do you have a specific requirement on when it could be merged? If not, I would merge it. |
no i have no specific requirement, you can merge it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support to amp-ad for the seedingalliance type.